Skip to content
This repository has been archived by the owner on Apr 4, 2022. It is now read-only.

🐛 fix(table): Add <td> min-height #102

Merged
merged 1 commit into from Oct 15, 2017
Merged

🐛 fix(table): Add <td> min-height #102

merged 1 commit into from Oct 15, 2017

Conversation

anselal
Copy link
Contributor

@anselal anselal commented Oct 15, 2017

Fixes #101
I applied the fix only to the _table.scss file. If the fix is correct you also need to recompile to css. Sorry but I am new to scss ;)

@Chalarangelo Chalarangelo changed the base branch from master to fermion.v2 October 15, 2017 13:42
Chalarangelo
Chalarangelo approved these changes Oct 15, 2017
View reviewed changes
Copy link
Owner

@Chalarangelo Chalarangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is correct, however I need to make it modular and apply to all flavors. It will be merged soon, made customizable and applied to all flavors. Expect a hotfix in the next few hours.

@Chalarangelo
Copy link
Owner

I changed the branch to fermion.v2, as the master branch is now going to be housing both Fermion and Gluon in the docs and it might cause some confusion. All subsequent PRs and releases will be based on fermion.v2.

Thanks you very much for the help @anselal, you are now part of the mini.css contributors club! 🎉

@anselal
Copy link
Contributor Author

anselal commented Oct 15, 2017

Thank you for giving me the opportunity to contribute. I have a lot to learn on SCSS and designing in general and I think I made a good start. I hope I will learn more so I can help this project grow.

@Chalarangelo Chalarangelo merged commit d15d657 into Chalarangelo:fermion.v2 Oct 15, 2017
@Chalarangelo
Copy link
Owner

mini.css is always looking for new contributors, so feel free to help with open issues or anything else. Reporting bugs and polishing features are just as important as writing the codebase in the first place. Community is everything! 😄

@anselal
Copy link
Contributor Author

anselal commented Oct 17, 2017

Will do my best to support your work !!! 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Chalarangelo Chalarangelo Chalarangelo approved these changes

Assignees
No one assigned
Labels
bug Fermion module table
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anselal @Chalarangelo