Skip to content
This repository has been archived by the owner on Apr 4, 2022. It is now read-only.

Wrong behavior when using <label> instead of <div> on angular #144

Closed
kennykarnama opened this issue Aug 3, 2018 · 1 comment
Closed

Wrong behavior when using <label> instead of <div> on angular #144

kennykarnama opened this issue Aug 3, 2018 · 1 comment

Comments

@kennykarnama
Copy link

  • Framework Version:
    v3.0.0
  • Flavor used:
    Angular app
  • Operating System/Browser:
    Ubuntu 18.04/Mozilla Firefox
  • Code to reproduce:
    <label for="modal-control" class="modal-close" ></label>
  • Bug description:
    When using angular, the label element gives wrong behavior. I suggest to change it to be
    <div for="modal-control" class="modal-close"></div>
@Chalarangelo
Copy link
Owner

Using <div> is semantically incorrect. As far as I'm concerned, this is more of an issue with how angular deals with things rather than an issue with the framework.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Chalarangelo @kennykarnama