Skip to content
This repository has been archived by the owner on Apr 4, 2022. It is now read-only.

Support for more [colour] icons #146

Closed
anselal opened this issue Sep 21, 2018 · 8 comments
Closed

Support for more [colour] icons #146

anselal opened this issue Sep 21, 2018 · 8 comments

Comments

@anselal
Copy link
Contributor

anselal commented Sep 21, 2018

Hi there,

is it possible to add more feather icons ?

I would like some icons like delete and add which are helpful when creating forms etc.

Also is it possible to add colour to the icons ?

@anselal anselal changed the title Support for more icons Support for more [color] icons Sep 21, 2018
@anselal anselal changed the title Support for more [color] icons Support for more [colour] icons Sep 21, 2018
@dtmpsc
Copy link

dtmpsc commented Sep 21, 2018

They're all in the CSS file, down near the bottom. For instance, I added the heart icon.

span.icon-heart {
background-image: url("data:image/svg+xml;charset=UTF-8,%3csvg xmlns='http://www.w3.org/2000/svg' width='24' height='24' viewBox='0 0 24 24' fill='none' stroke='currentColor' stroke-width='2' stroke-linecap='round' stroke-linejoin='round' class='feather feather-heart'%3e%3cpath d='M20.84 4.61a5.5 5.5 0 0 0-7.78 0L12 5.67l-1.06-1.06a5.5 5.5 0 0 0-7.78 7.78l1.06 1.06L12 21.23l7.78-7.78 1.06-1.06a5.5 5.5 0 0 0 0-7.78z'%3e%3c/path%3e%3c/svg%3e");
}

Just download the svg of the icon you wish to add, then convert it here:

https://codepen.io/elliz/full/ygvgay

@anselal
Copy link
Contributor Author

anselal commented Sep 21, 2018

Nice !!! Thnx !!!

@anselal
Copy link
Contributor Author

anselal commented Sep 24, 2018

@Chalarangelo Is it ok if I create a PR and add more feather icons ?

@Chalarangelo
Copy link
Owner

@anselal Not really. The icon set and amount of items is pretty much locked, just to keep the filesize small. I was planning to make an icon tool that will add icons on-demand, but work got in the way and I have very limited time to do so. Maybe you could help with that, so that people can add icons to their flavors as they please?

@anselal
Copy link
Contributor Author

anselal commented Sep 24, 2018

My time is limited too due to work load but If you could give me some instructions on how you would like this tool to be I could try to implement it.
What exactly do yo have in mind ?

@Chalarangelo
Copy link
Owner

I was thinking a tool that uses the Feather package to get a list of images, then lets the users choose which ones they want to add to their flavor and they are added via SCSS to the flavor file or single, small CSS files with the icons as classes.

@anselal
Copy link
Contributor Author

anselal commented Oct 1, 2018

I see. Perhaps we can pre-create the SCSS for the feather-icons so it would be easier to add them to the flavor. Maybe we can create a feathericons-css inside https://github.com/feathericons

You think we can contact them and ask to give us write access to a repo inside their organization ?

@Chalarangelo
Copy link
Owner

I am going to close due to inactivity. Feel free to comment below to reopen if you want to help with this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants