Skip to content
This repository has been archived by the owner on Apr 4, 2022. It is now read-only.

Modal dialog causing problems #3

Closed
Chalarangelo opened this issue Sep 21, 2016 · 2 comments
Closed

Modal dialog causing problems #3

Chalarangelo opened this issue Sep 21, 2016 · 2 comments
Assignees
@Chalarangelo
Labels
bug
Milestone
v1.0.1 Minor patc...

Comments

@Chalarangelo
Copy link
Owner

Due to the way the modal dialog is structured (opacity: 0 when not visible), it will sometimes cause problems with other things not being clickable as it will be displayed over them even if invisible. This can be easily remedied by changing the default state of the modal dialog (when not visible) to either use a z-index of -1 or similar (might have some problems with tabs using that specific z-index) or set it to display: none and display: block for its two different states.
@Chalarangelo Chalarangelo self-assigned this Sep 21, 2016
@Chalarangelo
Copy link
Owner Author

Here's a screenshot of the issue reproduced in Firefox:
Modal overlap

Chalarangelo added a commit that referenced this issue Sep 28, 2016
@Chalarangelo
Modal fix (issue #3)
94eddbe
Chalarangelo added a commit that referenced this issue Sep 28, 2016
@Chalarangelo
Better modal fix (transition display was problematic) - issue #3.
b3e2b8b
@Chalarangelo
Copy link
Owner Author

Modal dialog display has been now fixed. Original display used width :0 to width: 100%, however this caused some problems with the animation. The new fix uses display: none to display: block to ensure no such problems exist.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Chalarangelo Chalarangelo

Labels
bug
Projects
None yet
Milestone
v1.0.1 Minor patch for Neutrino
Development

No branches or pull requests
1 participant
@Chalarangelo