Skip to content
This repository has been archived by the owner on Apr 4, 2022. It is now read-only.

Empty <td data-label="Test"></td> breaks table layout #101

Closed
anselal opened this issue Oct 15, 2017 · 9 comments
Closed

Empty <td data-label="Test"></td> breaks table layout #101

anselal opened this issue Oct 15, 2017 · 9 comments

Comments

@anselal
Copy link
Contributor

anselal commented Oct 15, 2017

I noticed that when the <td> is empty and we have specified a data-label then the table layout breaks at that point. In the attached screenshot the "td 3' is empty.
2017-10-15_14h21_24

@anselal
Copy link
Contributor Author

anselal commented Oct 15, 2017

A hack to fix this is to add a &nbsp if there is no value for that field but I was wondering if this could be fixed within the framework

@Chalarangelo
Copy link
Owner

Chalarangelo commented Oct 15, 2017

I was literally writing about &nbsp; a second ago. This is a problem I have never encountered, but then again I have not had empty <td> elements. I will try to fix this asap and release a hotfix in the next couple of days. Sorry for the inconvenience!

I am also tagging this as help wanted and good first issue for new contributors to work on, if they so desire, as I am a little bit swamped with Gluon and other projects. However, this is a high priority bug that will be fixed! You have my word.

@anselal
Copy link
Contributor Author

anselal commented Oct 15, 2017

Maybe setting a minimum default height for the rows will fix the issue.

@Chalarangelo
Copy link
Owner

@anselal that sounds like a plausible solution. You could give it a try and, if it works, you could open a PR?

@anselal
Copy link
Contributor Author

anselal commented Oct 15, 2017

I will give it a quick try but I don't promise anything since I am not familiar with scss yet

@Chalarangelo
Copy link
Owner

@anselal try it in CSS in a Codepen or something. If it works, I will patch up the SCSS myself and release it immediately. Sorry for not looking into it right away, I have a college assignment that is due in two days and time is extremely limited till tomorrow.

Chalarangelo added a commit that referenced this issue Oct 15, 2017
Ready to release v2.3.5
@Chalarangelo
Copy link
Owner

Resolved in 7fb18b0 and released in v2.3.5. Thanks for reporting and helping resolve this!

@anselal
Copy link
Contributor Author

anselal commented Nov 20, 2017

Hi there,

I was reading about table formatting with css and stepped into a property which maybe is a better solution than the one o proposed earlier. Are you aware of the css property empty-cells: inherit; ?
May this one is better than adding a default minimum width ?

@Chalarangelo
Copy link
Owner

No, I have never seen this before. In fact, Can I use... does not even find it if I search for it. W3Schools mentions it is CSS2 so it should be supported well enough. I will look into it and see if it's any better than the existing solution. Thanks for the heads up!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants